-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crates] Added crate size badge #10421
Conversation
|
Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size |
Will point back to #9703 (comment) as I believe our position is still the same. Our main goal is consistency within the Shields ecosystem, but we can certainly consider offering support for these types of variances when it makes sense |
🚀 Updated review app: https://pr-10421-badges-shields.fly.dev |
Thanks for digging that comment out. I knew it had come up before. Lets keep the scope of this PR to just merging this in its current form. I am going to write up another issue about this topic. I do think it is worth doing though. |
I've raised #10437 and laid out my thoughts on this. |
🚀 Updated review app: https://pr-10421-badges-shields.fly.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this
Proposed in #6011
Didn't make the issue but last message was 2021 so I figured it was safe and I needed this.
Routes:
Crates.io Size: /crates/size/:crate
Crates.io Size (version): /crates/size/:crate/:version