Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crates] Added crate size badge #10421

Merged
merged 7 commits into from
Aug 4, 2024
Merged

[Crates] Added crate size badge #10421

merged 7 commits into from
Aug 4, 2024

Conversation

einstein8612
Copy link
Contributor

Proposed in #6011

Didn't make the issue but last message was 2021 so I figured it was safe and I needed this.

Routes:
Crates.io Size: /crates/size/:crate
Crates.io Size (version): /crates/size/:crate/:version

Copy link
Contributor

github-actions bot commented Jul 28, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @einstein8612!

Generated by 🚫 dangerJS against b712464

@einstein8612
Copy link
Contributor Author

Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size

@calebcartwright
Copy link
Member

Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size

Will point back to #9703 (comment) as I believe our position is still the same.

Our main goal is consistency within the Shields ecosystem, but we can certainly consider offering support for these types of variances when it makes sense

Copy link
Contributor

github-actions bot commented Aug 2, 2024

🚀 Updated review app: https://pr-10421-badges-shields.fly.dev

@chris48s
Copy link
Member

chris48s commented Aug 2, 2024

Also, while doing this I realised that shields don't use **bibytes but divide by 1000 instead. I just followed what the rest of the badges do but are there any plans of adding support for this? Since there's now an inconsistency between the badge's number and the one on crates.io/docker/github repo size

Will point back to #9703 (comment) as I believe our position is still the same.

Thanks for digging that comment out. I knew it had come up before. Lets keep the scope of this PR to just merging this in its current form. I am going to write up another issue about this topic. I do think it is worth doing though.

@chris48s
Copy link
Member

chris48s commented Aug 2, 2024

I've raised #10437 and laid out my thoughts on this.

@chris48s chris48s added the service-badge New or updated service badge label Aug 3, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

🚀 Updated review app: https://pr-10421-badges-shields.fly.dev

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants