Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapcraft] - Added snapcraft last update badge #10610

Merged
merged 10 commits into from
Oct 14, 2024
Merged

[Snapcraft] - Added snapcraft last update badge #10610

merged 10 commits into from
Oct 14, 2024
+156 −0

Conversation

MohanKumarAmbati
Copy link
Contributor

  • Added last updated badge for Snapcraft.

Hi @chris48s, can you please add "hacktoberfest-accepted" label to this PR so that it is considered under it.

closes - #10300

Thanks in advance.

@MohanKumarAmbati MohanKumarAmbati marked this pull request as ready for review October 12, 2024 17:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @MohanKumarAmbati!

Generated by 🚫 dangerJS against 1c00585

@github-actions GitHub Actions
Copy link
Contributor

🚀 Updated review app: https://pr-10610-badges-shields.fly.dev

@chris48s chris48s added service-badge New or updated service badge hacktoberfest-accepted labels Oct 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Updated review app: https://pr-10610-badges-shields.fly.dev

chris48s
chris48s previously approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. No notes from me 👍

I just noticed that there was already a review app deployed for this, so I'm going to leave it open for the moment as I suspect @PyvesB might also be having a look.

PyvesB
PyvesB reviewed Oct 13, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was having a look as well. One small casing correction, otherwise looks good to me :)

services/snapcraft/snapcraft-last-update.service.js Outdated Show resolved Hide resolved
@PyvesB
Copy link
Member

PyvesB commented Oct 13, 2024

can you please add "hacktoberfest-accepted" label to this PR so that it is considered under it.

I've opted the whole repository into Hacktoberfest, this should no longer be needed.

@MohanKumarAmbati
Copy link
Contributor Author

can you please add "hacktoberfest-accepted" label to this PR so that it is considered under it.

I've opted the whole repository into Hacktoberfest, this should no longer be needed.

Thank you @PyvesB

@PyvesB PyvesB added this pull request to the merge queue Oct 14, 2024
Merged via the queue into badges:master with commit 1d2bf19 Oct 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

@chris48s chris48s chris48s left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohanKumarAmbati @PyvesB @chris48s