Deprecate [HackageDeps] service #10618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jNullj
added
needs-upstream-help
|
Thanks. Agree we should just get rid of this. When we need to remove a service, we initially replace it with a message that says "no longer available". That way users get some kind of explanation of what happened instead of just a There's docs on this in https://github.com/badges/shields/blob/master/doc/deprecating-badges.md and you could look at something like #10371 as an example. |
chris48s
removed
the
needs-upstream-help
HackageDeps will allways return a landing page with 200 and no text about outdated packages. The site is down and looking for someone to take over. Therefor api information is false and non functional.
jNullj
force-pushed
the
fix/service-test-green/hackage
branch
from
2d357ac
to
5f17d1f
Compare
jNullj
changed the title
|
My bad, didn't notice this section of the docs. Thanks for the example it saved me some time.
In the wild Github has about 2k usages of this badge |
PyvesB
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Badge will always return up to date falsely as the upstream site is closed and looking for someone to take over.
The first test if a package exist will always return 200 OK even when non existing as we get the landing page.
Then we will never get "outdated dependencies" as the landing page doesn't include that text.
I looked into the https://hackage.haskell.org/api and couldn't find a quick way to replace the current upstream.
Therefor i propose we remove this badge, this is misleading at best as it's now.