Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate examples to openApi part 2; affects [archlinux bitcomponents bountysource cdnjs chrome clearlydefined clojars cocoapods coincap] #9428

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

chris48s
Copy link
Member

Refs #9285

..and so begins the long slow process of working through these. The first batch I am working on is classes with:

  • currently passing service tests
  • only path params
  • either one example, or two examples due to optional path params (e.g: branch*)
  • no documentation string

These are the most trivial services to convert, requiring the least manual work.
I am going to submit PRs touching batches of about 15-20 files at a time as I work through these.
Then I'll start moving onto slightly more complicated cases.

@chris48s chris48s added service-badge New or updated service badge documentation Developer and end-user documentation labels Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Warnings
⚠️ This PR modified service code for archlinux but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bit but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bountysource but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cdnjs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for chrome-web-store but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for clearlydefined but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for clojars but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cocoapods but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for coincap but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 0bd994a

@chris48s chris48s marked this pull request as draft July 31, 2023 19:20
@chris48s chris48s changed the title migrate examples to openApi part 2; affects [archlinux bitcomponents bountysource cdnjs chrome clearlydefined clojars cocoapods codefactor coincap] migrate examples to openApi part 2; affects [archlinux bitcomponents bountysource cdnjs chrome clearlydefined clojars cocoapods coincap] Aug 1, 2023
@chris48s chris48s marked this pull request as ready for review August 1, 2023 18:52
@calebcartwright calebcartwright added this pull request to the merge queue Aug 8, 2023
Merged via the queue into badges:master with commit b2f47a3 Aug 9, 2023
21 checks passed
nyurik pushed a commit to nyurik/shields that referenced this pull request Aug 9, 2023
…nts bountysource cdnjs chrome clearlydefined clojars cocoapods coincap] (badges#9428)

* convert an example that doesn't matter

* migrate some services from examples to openApi

* improve and de-dupe service titles

* revert changes to codefactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants