migrate examples to openApi part 7; affects [reuse sourceforge sourcegraph spack stackexchange testspace treeware twitch] #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
service-badge
|
PyvesB
previously approved these changes
Sep 2, 2023
| static openApi = { | ||
| '/sourceforge/commit-count/{project}': { | ||
| get: { | ||
| summary: 'SourceForge commit count', |
There was a problem hiding this comment.
Nit: we seem to prefer capitalising all words within the badge title, even though we're not consistent across the board. We should probably agree on one or the other. In this particular instance, there's inconsistency within different SourceForge badges themselves, so maybe we could at least fix these? Feel free to dismiss if you don't want to do this now, after all this inconsistency was already present before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9285
..and so begins the long slow process of working through these. The first batch I am working on is classes with:
branch*)These are the most trivial services to convert, requiring the least manual work.
I am going to submit PRs touching batches of about 15-20 files at a time as I work through these.
Then I'll start moving onto slightly more complicated cases.