Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate examples to openApi part 10 #9466

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

chris48s
Copy link
Member

Refs #9285

This one doesn't have passing service tests and I don't have the examples to hand to fix them, so I'm going to push a commit that does nothing, let the tests fail, then push a commit that does stuff so we can at least see the failures aren't new.

In general, this whole process probably will require modifying more code that doesn't have (reliably) passing service tests.

@chris48s chris48s added service-badge New or updated service badge documentation Developer and end-user documentation labels Aug 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

Warnings
⚠️ This PR modified service code for bitbucket but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 93e8877

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can circle back to fixinf failures later 👍

@chris48s chris48s changed the title migrate examples to openApi part 10; affects [bitbucketpipelines] migrate examples to openApi part 10 Sep 20, 2023
@chris48s chris48s added this pull request to the merge queue Sep 20, 2023
Merged via the queue into badges:master with commit dd97ee6 Sep 20, 2023
19 of 21 checks passed
@chris48s chris48s deleted the 9285-part10 branch September 20, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants