Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [testspace] badges #9525

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix [testspace] badges #9525

merged 2 commits into from
Sep 4, 2023

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Aug 29, 2023 •
edited
Loading

Closes #9515

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against e3fef9c

@chris48s chris48s changed the title WIP testspace WIP [testspace] Aug 29, 2023
@github-actions
Copy link
Contributor

🚀 Updated review app: https://pr-9525-badges-shields.fly.dev

@github-actions
Copy link
Contributor

🚀 Updated review app: https://pr-9525-badges-shields.fly.dev

@chris48s chris48s changed the title WIP [testspace] Fix [testspace] badges Aug 29, 2023
@chris48s chris48s marked this pull request as ready for review August 29, 2023 19:51
@chris48s chris48s added bug Bugs in badges and the frontend service-badge New or updated service badge labels Aug 29, 2023
PyvesB
PyvesB approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great investigation in the linked issue!

@chris48s chris48s added this pull request to the merge queue Sep 4, 2023
Merged via the queue into master with commit d179816 Sep 4, 2023
36 checks passed
@chris48s chris48s deleted the 9515-testspace branch September 4, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Testspace Test Results Badges is inaccessible
2 participants
@chris48s @PyvesB