log 429s to sentry (attempt 2); affects [dynamic endpoint uptimerobot weblate opencollective discord github] #9546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
service-badge
chris48s
commented
Sep 4, 2023
| @@ -74,6 +74,7 @@ export default class UptimeRobotBase extends BaseJsonService { | |||
| ...opts, | |||
| }, | |||
| }, | |||
| logErrors: [], | |||
There was a problem hiding this comment.
See #9155 for details.
The rate limits we're hitting here are on the user-supplied tokens. There's not really anything we can do about this.
chris48s
commented
Sep 4, 2023
| @@ -16,7 +16,7 @@ export default class OpencollectiveAll extends OpencollectiveBase { | |||
| }, | |||
| } | |||
|
|
|||
| static _cacheLength = 900 | |||
| static _cacheLength = 1800 | |||
There was a problem hiding this comment.
Lets see if this gets us consistently under the limits. If not, I'll raise an issue with OC and see if they'd be willing to grant us a higher limit.
|
PyvesB
approved these changes
Dec 2, 2023
Lordfirespeed
pushed a commit
to Lordfirespeed/shields
that referenced
this pull request
Dec 18, 2023
… weblate opencollective discord github] (badges#9546) * log to sentry if upstream service responds with 429 * allow services to decide which error(s) to log, default to 429 * don't log 429s from endpoint or dynamic badges * supress 429s from uptime robot badges * supress 429s from weblate if not calling default server * cache opencollective badges for longer * cache discord badges for longer * cache github workflow badges for longer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9505
Refs #9523
Closes #9524