Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I merged #9600
When I was working on shields today, I realised that docusaurus was outputting
This didn't cause anything to fail in CI - it just logged the errors to the console, which is why I didn't notice it.
The place where this is checked is https://github.com/facebook/docusaurus/blob/v2.4.3/packages/docusaurus/src/server/siteMetadata.ts#L75-L92
There doesn't appear to be any command or switch that can make this a hard error but I would really like this mismatch to cause a CI fail so I don't forget this next time. I am going to raise an issue about this upstream, but in the meantime I have cobbled together a crude bash script we can use. It is not very efficient because we have to build the whole frontend, but it is better than a kick in the teeth.
If you follow the commit history, you can see the build fails on the commit where I've added the check and then passes on the commit where I have fixed it.
FWIW, this particular mismatch (2.4.1 / 2.4.3) doesn't appear to actually be causing any issues, but I'd like to get this one reviewed/merged sooner rather than later.