增加模型列表获取的SDK #29
Merged
增加模型列表获取的SDK #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiriosPlus
reviewed
Jan 3, 2024
|
|
||
| """ | ||
| response = appbuilder.get_model_list(apiTypefilter=["chat"]) | ||
| self.assertIsNotNone(response) |
There was a problem hiding this comment.
只验证 返回是否为空， 需要进一步校验返回值的正确性
There was a problem hiding this comment.
apiTypefilter=["chat"]， filter的chat是什么含义
ide-rea
suggested changes
Jan 3, 2024
appbuilder/core/utils.py
Outdated
|
|
||
|
|
||
| def utils_get_user_agent(): | ||
| return 'appbuilder-sdk-python/{}'.format("__version__") | ||
|
|
||
|
|
||
| def get_model_list(secret_key: str = "", apiTypefilter: List[str] = [], is_available: bool = False): |
There was a problem hiding this comment.
get_model_list函数的返回类型是不是也可以说明下
appbuilder/core/utils.py
Outdated
|
|
||
|
|
||
| def utils_get_user_agent(): | ||
| return 'appbuilder-sdk-python/{}'.format("__version__") | ||
|
|
||
|
|
||
| def get_model_list(secret_key: str = "", apiTypefilter: List[str] = [], is_available: bool = False): |
There was a problem hiding this comment.
函数入参apiTypefilter，可以统一写成下划线
ide-rea
suggested changes
Jan 3, 2024
appbuilder/core/utils.py
Outdated
Comment on lines
39
to
59
| models = [] | ||
| if is_available: | ||
| for common_model in response.result.common: | ||
| if common_model.chargeStatus in ["OPENED", "FREE"]: | ||
| mapped_name = map_model_name(common_model.name) | ||
| models.append(mapped_name) | ||
|
|
||
| for custom_model in response.result.custom: | ||
| if custom_model.chargeStatus in ["OPENED", "FREE"]: | ||
| mapped_name = map_model_name(custom_model.name) | ||
| models.append(mapped_name) | ||
| return models | ||
| else: | ||
| for common_model in response.result.common: | ||
| mapped_name = map_model_name(common_model.name) | ||
| models.append(mapped_name) | ||
|
|
||
| for custom_model in response.result.custom: | ||
| mapped_name = map_model_name(custom_model.name) | ||
| models.append(mapped_name) | ||
| return models |
There was a problem hiding this comment.
可以使用一个迭代器，将通用模型与定制化模型连接起来，再进行遍历
import itertools
for model in itertools.chain(response.result.common, response.result.custom):
if is_available and common_model.chargeStatus not in ["OPENED", "FREE"]:
continue
mapped_name = map_model_name(common_model.name)
models.append(mapped_name)
added 2 commits
January 3, 2024 16:50
seiriosPlus
approved these changes
Jan 4, 2024
| None | ||
|
|
||
| """ | ||
| response = appbuilder.get_model_list(apiTypefilter=["chat"]) |
There was a problem hiding this comment.
- 函数命名是 小写， 参数是 驼峰， 需要统一
- apiTypefilter 缩短一下变量定义？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、utils目录下新建model_util.py文件，包含Models工具类，提供list()方法
2、utils.py里面新建get_model_list()工具方法，供用户调用