Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaConnectorConfig.name should be optional #412

Closed
sujuka99 opened this issue Jan 15, 2024 · 1 comment
Closed

KafkaConnectorConfig.name should be optional #412

sujuka99 opened this issue Jan 15, 2024 · 1 comment
Labels
component/pipeline-components Related to pipeline components

Comments

@sujuka99
Copy link
Contributor

We require the user to set the name in KafkaConnectorConfig, but it's then overwritten. The validator seems to accept that KafkaConnectorConfig.name could be None, so we should just make KafkaConnectorConfig.name optional.

@sujuka99 sujuka99 added the component/pipeline-components Related to pipeline components label Jan 15, 2024
@sujuka99 sujuka99 added this to the v3.0 milestone Jan 15, 2024
@sujuka99 sujuka99 removed this from the v3.0 milestone Jan 16, 2024
@disrupted
Copy link
Member

disrupted commented Jan 18, 2024

I believe that's not a good idea, name is a required attribute for Kafka Connector config. We do not require regular KPOps users to set it manually. For added convenience, KPOps takes care of it automatically so you don't have to repeat it in your YAML. Only if you're instantiating the class directly, language tools will show an error for the missing attribute, which is to be expected.

@sujuka99 sujuka99 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/pipeline-components Related to pipeline components
Projects
None yet
Development

No branches or pull requests

2 participants