You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We require the user to set the name in KafkaConnectorConfig, but it's then overwritten. The validator seems to accept that KafkaConnectorConfig.name could be None, so we should just make KafkaConnectorConfig.name optional.
The text was updated successfully, but these errors were encountered:
I believe that's not a good idea, name is a required attribute for Kafka Connector config. We do not require regular KPOps users to set it manually. For added convenience, KPOps takes care of it automatically so you don't have to repeat it in your YAML. Only if you're instantiating the class directly, language tools will show an error for the missing attribute, which is to be expected.
We require the user to set the name in KafkaConnectorConfig, but it's then overwritten. The validator seems to accept that KafkaConnectorConfig.name could be None, so we should just make
KafkaConnectorConfig.name
optional.The text was updated successfully, but these errors were encountered: