Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up fails for names > 63 chars #455

Closed
torbsto opened this issue Feb 15, 2024 · 0 comments · Fixed by #456
Closed

Clean up fails for names > 63 chars #455

torbsto opened this issue Feb 15, 2024 · 0 comments · Fixed by #456
Assignees
Labels
type/bug Something isn't working

Comments

@torbsto
Copy link
Contributor

torbsto commented Feb 15, 2024

In #390, hash-based trimming for Helm releases was already implemented. I now run into similar problems but with k8s resources. Having names bigger than 63 chars, KPOPs creates resources (in my case clean up jobs) with the same name and fails eventually because of it.

Also, it might fail because of auto-generated labels that are too long:

RuntimeError: Error: Job.batch "my-long-name" is invalid: [metadata.labels: Invalid value: "my-long-name": must be no more than 63 characters, spec.template.labels: Invalid value: "my-long-name: must be no more than 63 characters]
@torbsto torbsto added the type/bug Something isn't working label Feb 15, 2024
@torbsto torbsto changed the title Hash-based trimming for k8s resource names Clean up fails for names > 63 chars Feb 15, 2024
@disrupted disrupted self-assigned this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants