Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename generic app config to something more specific #502

Closed
philipp94831 opened this issue Jun 27, 2024 · 6 comments · Fixed by #506
Closed

Rename generic app config to something more specific #502

philipp94831 opened this issue Jun 27, 2024 · 6 comments · Fixed by #506
Assignees
Labels
component/pipeline-components Related to pipeline components
Milestone

Comments

@philipp94831
Copy link
Member

Currently, most components use app to specify its config. We should consider renaming it to something more specific so that the purpose becomes more clear.
Suggestions:

@disrupted disrupted added the component/pipeline-components Related to pipeline components label Jun 27, 2024
@raminqaf
Copy link
Contributor

I don't even understand what the config for Kubernetes does

@philipp94831 model_config is Paydantic's base model field for configuring your model. The [allow_extra](https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.extra) is defined as:

Whether to ignore, allow, or forbid extra attributes during model initialization.

@disrupted
Copy link
Member

I don't even understand what the config for Kubernetes does

@philipp94831 model_config is Paydantic's base model field for configuring your model. The [allow_extra](https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.extra) is defined as:

Whether to ignore, allow, or forbid extra attributes during model initialization.

I don't see how this is related to the issue

@disrupted disrupted self-assigned this Jul 8, 2024
@philipp94831
Copy link
Member Author

I linked to the wrong thing above. This is what I meant https://github.com/bakdata/kpops/blob/main/kpops/components/base_components/kubernetes_app.py#L42. Why does KubernetesApp has an app field if it is not used (or I don't see it). It makes sense to have it for HelmApp

@disrupted
Copy link
Member

but a plain Kubernetes app (which is not managed by a Helm chart) can also have values, e.g.

kubernetes-app:
  app:  # rename: values
    labels:
      foo: foo

@philipp94831
Copy link
Member Author

How are these used for deploying the app? Because there is no manifest template they are used for

@disrupted
Copy link
Member

true, this is not implemented as of yet. So far we're only using it for the enrichment for components inheriting from KubernetesApp, e.g. HelmApp and Cleaner/Resetter. In the future we would like to support standalone KubernetesApps, i.e. deploying them using the Kubernetes API.

@disrupted disrupted added this to the v7 milestone Jul 18, 2024
@disrupted disrupted mentioned this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/pipeline-components Related to pipeline components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants