-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename generic app
config to something more specific
#502
Comments
@philipp94831
|
I don't see how this is related to the issue |
I linked to the wrong thing above. This is what I meant https://github.com/bakdata/kpops/blob/main/kpops/components/base_components/kubernetes_app.py#L42. Why does KubernetesApp has an app field if it is not used (or I don't see it). It makes sense to have it for HelmApp |
but a plain Kubernetes app (which is not managed by a Helm chart) can also have values, e.g. kubernetes-app:
app: # rename: values
labels:
foo: foo |
How are these used for deploying the app? Because there is no manifest template they are used for |
true, this is not implemented as of yet. So far we're only using it for the enrichment for components inheriting from KubernetesApp, e.g. HelmApp and Cleaner/Resetter. In the future we would like to support standalone KubernetesApps, i.e. deploying them using the Kubernetes API. |
Currently, most components use
app
to specify its config. We should consider renaming it to something more specific so that the purpose becomes more clear.Suggestions:
values
for Helm (and Kubernetes? I don't even understand what the config for Kubernetes does https://github.com/bakdata/kpops/blob/main/kpops/components/base_components/kubernetes_app.py#L21)config
for Connectors (in line with https://docs.confluent.io/platform/current/connect/references/restapi.html#get--connectors-(string-name)-config)The text was updated successfully, but these errors were encountered: