Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm diff should not print old value if field is ignored #508

Closed
philipp94831 opened this issue Jul 9, 2024 · 0 comments · Fixed by #510
Closed

Helm diff should not print old value if field is ignored #508

philipp94831 opened this issue Jul 9, 2024 · 0 comments · Fixed by #510
Assignees
@disrupted
Labels
component/handlers Related to component handlers

Comments

@philipp94831
Copy link
Member

Currently, helm diff prints the old value for a field but not the new value if a field is ignored. While it is correct that the diff is not shown, the old value should also not be printed in order to avoid confusion about the value after deploying
@disrupted disrupted added the component/handlers Related to component handlers label Jul 9, 2024
@disrupted disrupted mentioned this issue Jul 9, 2024
Merged
@disrupted disrupted self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disrupted disrupted

Labels
component/handlers Related to component handlers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete ignored keys from diff bakdata/kpops
2 participants
@philipp94831 @disrupted