Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent Kubernetes Resources as valid Pydantic models #548

Closed
raminqaf opened this issue Dec 5, 2024 · 1 comment
Closed

Represent Kubernetes Resources as valid Pydantic models #548

raminqaf opened this issue Dec 5, 2024 · 1 comment
Assignees
@raminqaf
Milestone
Argo support

Comments

@raminqaf
Copy link
Contributor

raminqaf commented Dec 5, 2024

Currently the manifest command is returning a type alias called Resource. Resource is a sequence of dictionaries. There is no type validation. This should be changed. The new model will allow us to represent other Kubernetes resources like the StrimziKafkaTopic.
@raminqaf raminqaf self-assigned this Dec 5, 2024
@raminqaf raminqaf added this to the Argo support milestone Dec 5, 2024
@raminqaf raminqaf mentioned this issue Dec 5, 2024
Merged
raminqaf added a commit that referenced this issue Dec 5, 2024
@raminqaf
Define Pydantic model to representing Kubernetes manifest (#546)
ec6858a 
Closes #548
@raminqaf
Copy link
Contributor Author

raminqaf commented Dec 9, 2024

Closed by #546

@raminqaf raminqaf closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raminqaf raminqaf

Labels
None yet
Projects
None yet
Milestone
Argo support
Development

No branches or pull requests
1 participant
@raminqaf