Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toml formatter to dprint #386

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Add toml formatter to dprint #386

merged 8 commits into from
Nov 22, 2023

Conversation

sujuka99
Copy link
Contributor

@sujuka99 sujuka99 commented Nov 3, 2023

No description provided.

@sujuka99 sujuka99 added the area/CI Relates to GitHub actions label Nov 3, 2023
@sujuka99 sujuka99 requested a review from raminqaf as a code owner November 3, 2023 22:27
@sujuka99 sujuka99 self-assigned this Nov 3, 2023
dprint.json Outdated Show resolved Hide resolved
@disrupted
Copy link
Member

please also rename the dprint step in the CI since it's no longer specific to markdown files

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Co-authored-by: Ramin Gharib <ramin.gharib@bakdata.com>
irux
irux previously approved these changes Nov 22, 2023
Copy link
Contributor

@irux irux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raminqaf
raminqaf previously approved these changes Nov 22, 2023
@sujuka99 sujuka99 merged commit 60c2db0 into main Nov 22, 2023
8 checks passed
@sujuka99 sujuka99 deleted the ci/add-toml-formatter branch November 22, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Relates to GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants