Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests resources #417

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Update tests resources #417

merged 3 commits into from
Jan 16, 2024

Conversation

sujuka99
Copy link
Contributor

closes #411

@sujuka99 sujuka99 added the area/documentation Improvements or additions to documentation label Jan 16, 2024
@sujuka99 sujuka99 added this to the v3.0 milestone Jan 16, 2024
@sujuka99 sujuka99 self-assigned this Jan 16, 2024
@irux
Copy link
Contributor

irux commented Jan 16, 2024

Should you also update the examples we have under the kpops/examples folder (atm fraud) already in this PR ? Or in other one?

@sujuka99
Copy link
Contributor Author

Should you also update the examples we have under the kpops/examples folder (atm fraud) already in this PR ? Or in other one?

They are already up to date. This PR addresses changes that should have been done before, but we somehow missed.

Copy link
Contributor

@irux irux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sujuka99 sujuka99 merged commit 61bceca into v3 Jan 16, 2024
7 checks passed
@sujuka99 sujuka99 deleted the tests/update branch January 16, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants