-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KPOps 3.0 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Registry config (#354)
fixes #373 > I am getting this error when I try to use dry-run: subprocess.CalledProcessError: Command '['helm', 'get', 'manifest', 'account-producer', '--namespace', 'my-namespace']' returned non-zero exit status 1. why? does he launch it first in dry-run ? when I do that in my commandline I get To learn more, consult https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke Error: release: not found The [problem came from](2.0.9...2.0.10#diff-1ca7465daf9238dfe221304df636d96704ebf4935288b854a5c4c6b3ea9e3162R215) setting `subproces.run(..., check = True)` without handling the raised exception. I took some imports out of `TYPE_CHECKING` blocks to avoid problems with `pydantic` as it uses type hints at runtime Updated to the latest (`0.1.1`) version. Now all fixes deemed unsafe will not be automatically carried out even if it is possible to do so. The user can choose to enable the unsafe autofixes with the `--unsafe-fixes` flag While testing I noticed that we could use the namespace env var in some places in the example, so I did it and had to adjust the tests.
closes #341 --------- Co-authored-by: Salomon Popp <salomon.popp@bakdata.com>
closes #153 --------- Co-authored-by: Salomon Popp <salomon.popp@bakdata.com>
for added convenience, ability to set pipeline base dir and components module globally for the project. therefore it won't be necessary to specify these with each invocation will be used for automatic schema generation (editor integration)
Fixes #327 Remove previous workaround for setting Helm app `nameOverride` in favor of a more robust implementation in `HelmApp`
- Mark component type property as computed Pydantic field - Remove hack
`template` renamed to ~~`render`~~ `manifest` as it's no longer strictly tied to Helm template, can be used to render final resources of any pipeline component, e.g. Kubernetes manifest Extract `kpops generate --template` into separate ~~`kpops render`~~ `kpops manifest` command Return Kubernetes manifest as mapping for use with Python API Closes #103 --------- Co-authored-by: Ivan Yordanov <i.p.yordanov@proton.me>
Preceeds #398 --------- Co-authored-by: Salomon Popp <salomon.popp@bakdata.com>
Depends on #397 extracted the cleanup job needed for streams-bootstrap producer and streams apps to its own HelmApp nested inside the parent component - [x] Create docs for `StreamsBootstrap` base - [x] Update KPOps component inheritance graph - [x] Update docs gen for multiple component inheritance (#406)
Closes #410
irux
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.