Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Pyright to warn on unknown types #480

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Apr 3, 2024

Closes #367

"warning" diagnostics don't cause the pre-commit hook to fail, but you'll get those highlighted in the code when using Pyright/Pylance LSP

@disrupted disrupted added the area/CI Relates to GitHub actions label Apr 3, 2024
@disrupted disrupted self-assigned this Apr 3, 2024
Copy link
Contributor

@sujuka99 sujuka99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@disrupted disrupted marked this pull request as ready for review April 3, 2024 12:26
@disrupted disrupted requested review from raminqaf and irux as code owners April 3, 2024 12:26
@disrupted disrupted merged commit e168048 into main Apr 3, 2024
16 of 18 checks passed
@disrupted disrupted deleted the ci/pyright-warn-unknown branch April 3, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Relates to GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure pyright to warn when type cannot be inferred
2 participants