Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create generic SerializeAsOptional type for Pydantic #564

Merged
merged 31 commits into from
Dec 18, 2024
Merged

Create generic SerializeAsOptional type for Pydantic #564

merged 31 commits into from
Dec 18, 2024

Conversation

disrupted
Copy link
Member

No description provided.

@disrupted disrupted self-assigned this Dec 12, 2024
@disrupted disrupted changed the title Create annotated list type that serializes to None if empty Create generic SerializeAsOptional type for Pydantic Dec 12, 2024
@disrupted disrupted marked this pull request as ready for review December 12, 2024 20:07
@disrupted disrupted requested a review from raminqaf as a code owner December 12, 2024 20:07
philipp94831
philipp94831 reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@philipp94831 philipp94831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this to StreamsBootstrapValues?

@disrupted disrupted marked this pull request as draft December 16, 2024 14:04
@disrupted disrupted marked this pull request as ready for review December 16, 2024 17:54
@disrupted disrupted added type/refactor Refactoring of existing functionality component/pipeline-components Related to pipeline components labels Dec 17, 2024
@disrupted disrupted merged commit fd1acf5 into main Dec 18, 2024
9 checks passed
@disrupted disrupted deleted the refactor/pydantic-optional-list branch December 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raminqaf raminqaf raminqaf approved these changes

@philipp94831 philipp94831 philipp94831 approved these changes

Assignees

@disrupted disrupted

Labels
component/pipeline-components Related to pipeline components type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disrupted @philipp94831 @raminqaf @bakdata-bot