Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Managed pools tokens weights #538

Open
mendesfabio opened this issue Dec 7, 2023 · 1 comment
Open

fix Managed pools tokens weights #538

mendesfabio opened this issue Dec 7, 2023 · 1 comment

Comments

@mendesfabio
Copy link
Member

mendesfabio commented Dec 7, 2023 •
edited
Loading

The weight attribute is null for Managed pools tokens. After a quick investigation, I found that:

  • weights are never set at the creation because Managed has pre-minted BPT - this condition is always falsy
  • updatePoolWeights is not called on every Managed pool Swap event

Requirements

  • Add Managed to isVariableWeightPool function
  • Remove BPT from tokensList before comparing to weights
@mendesfabio mendesfabio changed the title fix Managed pools weights fix Managed pools tokens weights Dec 7, 2023
@mendesfabio mendesfabio mentioned this issue Dec 8, 2023
Merged
11 tasks
@mendesfabio
Copy link
Member Author

I deployed a fix to staging -- will get back into this after sync is complete (hopefully Monday)

@mendesfabio mendesfabio mentioned this issue Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mendesfabio