Improve naming

balancer · Jan 11, 2024 · 1635898 · 1635898
1 parent d92032b
commit 1635898
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts b/lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts
@@ -15,6 +15,7 @@ import { LiquidityActionHelpers, areEmptyAmounts } from '../../LiquidityActionHe
 import { HumanAmountIn } from '../../liquidity-types'
 import { BuildAddLiquidityInputs, QueryAddLiquidityOutput } from '../add-liquidity.types'
 import { AddLiquidityHandler } from './AddLiquidity.handler'
+import { SentryError } from '@/lib/shared/utils/errors'
 
 /**
  * UnbalancedAddLiquidityHandler is a handler that implements the
@@ -69,9 +70,9 @@ export class UnbalancedAddLiquidityHandler implements AddLiquidityHandler {
   }: BuildAddLiquidityInputs): Promise<TransactionConfig> {
     if (!this.queryResponse) {
       // This should never happen because we don't allow the user to trigger buildAddLiquidityCallData
-      // before the query is loaded. QUESTION: Is there a more explicit way?
+      // before the query is loaded.
       console.error('Missing queryResponse.')
-      throw new Error(
+      throw new SentryError(
         `Missing queryResponse.
 It looks that you tried to call useBuildCallData before the last query finished generating queryResponse`
       )

diff --git a/lib/modules/pool/actions/add-liquidity/useConstructAddLiquidityStep.ts b/lib/modules/pool/actions/add-liquidity/useConstructAddLiquidityStep.ts
@@ -10,11 +10,11 @@ export function useConstructAddLiquidityStep(poolId: string) {
 
   const { useBuildCallData } = useAddLiquidity()
 
-  const addLiquidityQuery = useBuildCallData(isActiveStep)
+  const buildCallDataQuery = useBuildCallData(isActiveStep)
 
   const transactionLabels = buildAddLiquidityLabels(poolId)
 
-  const transaction = useManagedSendTransaction(transactionLabels, addLiquidityQuery.data)
+  const transaction = useManagedSendTransaction(transactionLabels, buildCallDataQuery.data)
 
   const step: FlowStep = {
     ...transaction,
@@ -30,14 +30,15 @@ export function useConstructAddLiquidityStep(poolId: string) {
     isLoading:
       transaction?.simulation.isLoading ||
       transaction?.execution.isLoading ||
-      addLiquidityQuery.isLoading,
-    error: transaction?.simulation.error || transaction?.execution.error || addLiquidityQuery.error,
+      buildCallDataQuery.isLoading,
+    error:
+      transaction?.simulation.error || transaction?.execution.error || buildCallDataQuery.error,
   }
 }
 
 export const buildAddLiquidityLabels: BuildTransactionLabels = (poolId: Address) => {
   return {
-    init: 'Add pool liquidity',
+    init: 'Add liquidity',
     confirming: 'Confirm add liquidity',
     tooltip: 'TODO',
     description: `🎉 Liquidity added to pool ${poolId}`,