chore: improve naming

balancer · Oct 1, 2024 · ae4198c · ae4198c
1 parent 46a2f82
commit ae4198c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/lib/modules/pool/actions/add-liquidity/handlers/BaseUnbalancedAddLiquidity.handler.ts b/lib/modules/pool/actions/add-liquidity/handlers/BaseUnbalancedAddLiquidity.handler.ts
@@ -15,7 +15,7 @@ import { SdkBuildAddLiquidityInput, SdkQueryAddLiquidityOutput } from '../add-li
 import { AddLiquidityHandler } from './AddLiquidity.handler'
 
 /**
- * Base abstract class that shares common logic shared by v3 and v2/v1 pool handlers
+ * Base abstract class that shares common logic shared by v3 and v2/v1 pool unbalanced handlers
  */
 export abstract class BaseUnbalancedAddLiquidityHandler implements AddLiquidityHandler {
   protected helpers: LiquidityActionHelpers

diff --git a/lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts b/lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts
@@ -32,8 +32,6 @@ export class UnbalancedAddLiquidityHandler extends BaseUnbalancedAddLiquidityHan
       account
     )
 
-    console.log({ buildCallParams })
-
     const { callData, to, value } = addLiquidity.buildCall(buildCallParams)
 
     return {

diff --git a/lib/modules/tokens/approvals/permit2/signPermit2TokenTransfer.tsx b/lib/modules/tokens/approvals/permit2/signPermit2TokenTransfer.tsx
@@ -42,14 +42,14 @@ export async function signPermit2TokenTransfer(
   }
 }
 
-// TODO: refactor to object parameters
 async function signPermit2({
   sdkClient,
   pool,
   humanAmountsIn,
   permit2Input,
   nonces,
 }: SignPermit2Params): Promise<Permit2> {
+  if (!sdkClient) throw new Error('Missing sdkClient')
   const baseInput = constructBaseBuildCallInput({
     humanAmountsIn,
     slippagePercent: permit2Input.slippagePercent,
@@ -59,7 +59,7 @@ async function signPermit2({
   })
   const signature = await Permit2Helper.signAddLiquidityApproval({
     ...baseInput,
-    client: sdkClient!,
+    client: sdkClient,
     owner: permit2Input.account,
     nonces: baseInput.amountsIn.map(a => nonces[a.token.address]),
   })