Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tenderly url improvements #1090

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat: tenderly url improvements #1090

merged 3 commits into from
Sep 16, 2024

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Sep 16, 2024

We have some issues in sentry when the SDK throws an RPC Request invalid error (from viem) during a simulation or priceImpact query.

When the error contains build call data info, we can parse it and build a tenderly url to better understand the issue.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 0:49am
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 0:49am

@agualis agualis changed the title Feat/tenderly url improvements feat: tenderly url improvements Sep 16, 2024
Copy link
Contributor

@garethfuller garethfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see my comment about gas/gasPrice? Last time I tested out one of these tenderly URLs it didn't work until I removed them from the URL params.

@agualis agualis merged commit 06150e1 into main Sep 16, 2024
7 checks passed
@agualis agualis deleted the feat/tenderlyUrlImprovements branch September 16, 2024 14:55
agualis added a commit that referenced this pull request Sep 16, 2024
* feat: get tenderly url from error message

* chore: improve error message for RPC Request failed error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants