feat: add liquidity unbalanced permit2 #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agualis
commented
Sep 25, 2024
| @@ -106,4 +134,22 @@ export class UnbalancedAddLiquidityHandler implements AddLiquidityHandler { | |||
| kind: AddLiquidityKind.Unbalanced, | |||
| } | |||
| } | |||
|
|
|||
| public constructBaseBuildCallInput({ | |||
There was a problem hiding this comment.
I will probably try to extract this method to be shared by all the handlers but for now I will keep it here until I implement the rest of the v3 handlers
agualis
commented
Sep 25, 2024
| slippage: Slippage.fromPercentage(`${Number(slippagePercent)}`), | ||
| wethIsEth: this.helpers.includesNativeAsset(sdkQueryOutput.amountsIn), | ||
| } | ||
| // baseBuildCallParams.amountsIn = baseBuildCallParams.amountsIn.filter( |
There was a problem hiding this comment.
I will delete this later. It is a reminder to try something...
agualis
commented
Sep 25, 2024
| }) | ||
| console.log('Call data built:', response) | ||
| if (permit2) console.log('permit2 for call data:', permit2) |
There was a problem hiding this comment.
We can leave this comment in production for debugging purposes or we can remove it if we see that permit2 is not problematic.
4 tasks
agualis
commented
Oct 4, 2024
There was a problem hiding this comment.
Should we rename this file/class to UnbalancedAddLiquidityV2.handler.ts to make it more explicit? Note that it also used for V1 CowAMM pools to that would not be precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds v3 permit2 flow only for unbalanced add handler.
Contains many TODOs but let's merge it before moving to the monorepo.
Note: It only works pointing to
test apiin.env.localas sepolia v3 pools are not yet inproduction apipermit2Adds.mp4