fix: receipt animations #1128
Merged
fix: receipt animations #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
garethfuller
approved these changes
Sep 25, 2024
garethfuller
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix: change waitForReceipt timeout to undefined to avoid wagmi bug * mend * fix: avoid animations when rendering a historic receipt (#1128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids animations and
currentStep?.renderAction()rendering when opening a historic receipt as it was causing flickering and other random issues.Before: (you can see
Switch network to Ethereumbutton rendered for some ms)beforeTx.mp4
After:
afterTx.mp4
Fixes other random issues that I couldn't consistently reproduce.