-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add permit2 subSteps #1141
base: feat/addLiquidityPermit2
Are you sure you want to change the base?
Conversation
* chore: migrate to dRPC * chore: disable foundry cache in GHA
* chore: Init * feat: add prop slippage count down animation * refactor: remove logs and comments * feat: remove animation * chore: Adjust balances * chore: Adjust balances in provider * chore: Cleanup * chore: Revert numbers change --------- Co-authored-by: Anastasios <anastas3993@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -23,9 +23,9 @@ export function Steps({ transactionSteps }: Props) { | |||
colorMode={colorMode} | |||
isLastStep={isLastStep(index)} | |||
/> | |||
{!isLastStep(index) && ( | |||
{/* {!isLastStep(index) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uiuxxx I commented out this vertical separator that only worked when no subSteps are present. We need something that looks good in both scenarios
function SubSteps({ color, subSteps }: { color: string; subSteps: SubSteps }) { | ||
return ( | ||
<Box mt="1" pl="2" p="1"> | ||
{subSteps.gas === 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uiuxxx For now I only show Signature: Free
for permit substeps. I want to finish implementing the pool actions and then we can talk about the gas implementation depending of the available time left.
Example of weighted pool for testing
permit2 add liquidity
:https://test-v3-git-feat-substeps-balancer.vercel.app/pools/sepolia/v3/0x3e8b62395aea51c3d7bdfeb8cde7d4a272c34750/add-liquidity