-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add permit2 subSteps #1141
Open
agualis
wants to merge
8
commits into
feat/addLiquidityPermit2
Choose a base branch
from
feat/subSteps
base: feat/addLiquidityPermit2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
58ade34
chore: ignore extensionPageScript error in sentry (#1140)
agualis c0f1936
chore: bump sdk to 0.27.0 (#1139)
agualis fe5044e
chore: migrate to dRPC (#1138)
agualis 1a6ffc2
feat: Allow slippage on forced proportional adds (#1133)
garethfuller 4639f63
feat: add permit subSteps
agualis 55b6a04
chore: delete debug div
agualis 9ab3a5a
Merge branch 'main' into feat/subSteps
agualis deb70ff
chore: add nested gas details
agualis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { Box, VStack } from '@chakra-ui/react' | ||
import { VStack } from '@chakra-ui/react' | ||
import { Step } from './Step' | ||
import { useThemeColorMode } from '@/lib/shared/services/chakra/useThemeColorMode' | ||
import { TransactionStepsResponse } from '../useTransactionSteps' | ||
|
@@ -23,9 +23,9 @@ export function Steps({ transactionSteps }: Props) { | |
colorMode={colorMode} | ||
isLastStep={isLastStep(index)} | ||
/> | ||
{!isLastStep(index) && ( | ||
{/* {!isLastStep(index) && ( | ||
<Box h="4" w="1" rounded="full" background="border.base" ml="3" mt="1" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @uiuxxx I commented out this vertical separator that only worked when no subSteps are present. We need something that looks good in both scenarios |
||
)} | ||
)} */} | ||
</div> | ||
))} | ||
</VStack> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,10 @@ | ||
// Common labels used in app, helps keep common text consitent and easy to change. | ||
// Common labels used in app, helps keep common text consistent and easy to change. | ||
export const LABELS = { | ||
walletNotConnected: 'Wallet not connected', | ||
} | ||
|
||
// Converts an index to a letter. 0 is A, 1 is B, etc. | ||
export function indexToLetter(index: number): string { | ||
if (index >= 0 && index <= 25) return String.fromCharCode(index + 65) | ||
throw new Error('index but be between 0 and 25') | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uiuxxx For now I only show
Signature: Free
for permit substeps. I want to finish implementing the pool actions and then we can talk about the gas implementation depending of the available time left.