Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maximize liquidity in sepolia #1142

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: maximize liquidity in sepolia #1142

merged 1 commit into from
Oct 3, 2024

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Oct 3, 2024 •
edited
Loading

The API is not currently not returning 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee native tokens for sepolia:

query {
  tokenGetTokens(chains: [SEPOLIA]) {
    address
  }
}

That breaks maximize feature in sepolia.

Before:

before

After:

after

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:21am
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:21am

@agualis agualis changed the title fix: maximize when pool does not have native assets fix: maximize liquidity in sepolia Oct 3, 2024
@agualis agualis merged commit 430f456 into main Oct 3, 2024
7 checks passed
@agualis agualis deleted the fix/maximizeWithoutNativeTokens branch October 3, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groninge01 groninge01 groninge01 approved these changes

@garethfuller garethfuller Awaiting requested review from garethfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agualis @groninge01