Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - <PoolMetaBadges> #137

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Feature - <PoolMetaBadges> #137

merged 3 commits into from
Dec 15, 2023

Conversation

arb000r
Copy link
Collaborator

@arb000r arb000r commented Dec 10, 2023

Description

Adds the token / fee / chain meta badges at the top of the pool page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Pool page

Visual context

image

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 2:09pm

Comment on lines +17 to +18
background="lightBadge"
_dark={{ background: 'background.card.level6' }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you guys think, I can themify this. I didn't think it needed it however.

@garethfuller
Copy link
Contributor

Is there anything in the designs to indicate what that percentage is? I realise it's the swap fee, but we need to help the user understand that. @uiuxxx

@uiuxxx
Copy link
Contributor

uiuxxx commented Dec 12, 2023

Is there anything in the designs to indicate what that percentage is? I realise it's the swap fee, but we need to help the user understand that. @uiuxxx

I think we should do an icon / info tooltip to help explain what it is, especially since some fees are dynamic and set by governance. I'll design a tooltip around it.

@arb000r
Copy link
Collaborator Author

arb000r commented Dec 13, 2023

I'll add a tooltip which can be themed. Would be good to get some text on that though

@garethfuller garethfuller merged commit 3e381d9 into main Dec 15, 2023
6 checks passed
@garethfuller garethfuller deleted the feature/Pool-Meta-Badges branch December 15, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants