Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes some issues with the user address pool filter #195

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

garethfuller
Copy link
Contributor

@garethfuller garethfuller commented Jan 9, 2024

Description

  • The RSC query needed the userAddress param in the attributes to prevent a second fetch on page load.
  • Hide the filter option if no wallet is connected.
  • If the user changes address in wallet and has previously applied the 'My liquidity' filter we should swap out the address for the new one.
  • There was a bug in the usePoolOrderByState that caused additional table columns to be added everytime you connected a new address.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Test filtering by userAddress, switch accounts, disconnect and reconnect.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview Jan 9, 2024 4:23pm

@garethfuller garethfuller self-assigned this Jan 9, 2024
@garethfuller garethfuller merged commit adce4ef into main Jan 10, 2024
6 checks passed
@garethfuller garethfuller deleted the fix/user-address-filter branch January 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants