Spike [handlers]: explicit relationship between query and buildCallData signatures #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lib/modules/pool/actions/add-liquidity/queries/useAddLiquidityPreviewQuery.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+46
to
+56
| const isSdkHandler = 'sdkQueryOutput' in queryOutput && queryOutput.sdkQueryOutput | ||
|
|
||
| if (isSdkHandler) { | ||
| const sdkBuildInput: SdkBuildAddLiquidityInputs = { | ||
| ...baseInput, | ||
| sdkQueryOutput: queryOutput.sdkQueryOutput, | ||
| } | ||
| return handler.buildAddLiquidityCallData(sdkBuildInput) | ||
| } | ||
| if (handler instanceof TwammAddLiquidityHandler) { | ||
| return handler.buildAddLiquidityCallData(baseInput) |
There was a problem hiding this comment.
Why not pass the whole queryOutput into the handler build call on the handler?
There was a problem hiding this comment.
Feels like it doesn't make sense to do this conditional deconstruction in this query. The handler should just know what it's getting because of the type, shouldn't it?
agualis
changed the title
agualis
changed the title
agualis
changed the title
|
Closed by #211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
AddLiquidityHandlerinterface to depend on generic TS types.The new code is more verbose but also more explicit and type-safe.
Now we can have
Default SDK handlers where:
SdkQueryAddLiquidityOutputthat contains a mandatorysdkQueryOutput: AddLiquidityQueryOutputfieldEdge case handlers (added a fake Twamm handler example )where:
sdkQueryOutput: AddLiquidityQueryOutputfieldbptOutfieldType of change
expected)
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test
configuration.
Visual context
Please provide any relevant visual context for UI changes or additions. This could be static
screenshots or a loom screencast.
Checklist: