-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/add liquidity inputs #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
garethfuller
approved these changes
Jan 16, 2024
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts
Outdated
Show resolved
Hide resolved
danielmkm
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, much cleaner.
lib/modules/pool/actions/add-liquidity/handlers/UnbalancedAddLiquidity.handler.ts
Outdated
Show resolved
Hide resolved
This was referenced Jan 16, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final implementation of add liquidity handlers using:
buildCallData
inputQueryAddLiquidityOutput
inside handlers:Closes the other related spikes: #196 #206 #209
Type of change
expected)
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test
configuration.
Visual context
Please provide any relevant visual context for UI changes or additions. This could be static
screenshots or a loom screencast.
Checklist: