Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/add liquidity inputs #211

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Refactor/add liquidity inputs #211

merged 8 commits into from
Jan 16, 2024

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Jan 16, 2024

Description

Final implementation of add liquidity handlers using:

  • Explicit preview query output as part of the signature of the buildCallData input
  • Non generic TS types
  • Explicit SDK interfaces extending generic QueryAddLiquidityOutput inside handlers:
interface SdkQueryAddLiquidityOutput extends QueryAddLiquidityOutput {
  sdkQueryOutput: AddLiquidityQueryOutput
}

export interface SdkBuildAddLiquidityInput extends BuildAddLiquidityInput {
  queryOutput: SdkQueryAddLiquidityOutput
}

Closes the other related spikes: #196 #206 #209

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test
configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static
screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 3:55pm

Copy link
Collaborator

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, much cleaner.

Copy link

sentry-io bot commented Jan 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'length') useIsMounted(lib/modules/web3/useIsMounted.ts) View Issue
  • ‼️ TypeError: Cannot read properties of null (reading 'some') some(lib/modules/pool/actions/LiquidityActionHe... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants