Daily Standups

[MattPereira]

This issue is for tracking daily progress and prioritization planning

[MattPereira]

April 18th

Yesterday

• Reviewed feedback from Balancer
• Implemented fixes on Implement the PoolActions component #12 based on feedback received

Today

• Communicate with Balancer about the updates
• Offer more feedback on SDK to Balancer

[steve0xp]

April 18th Stand-Up

Yesterday

• Worked on custom pool PR, added in fake ERC20s to work with in terms of creating new pool factories and pools.
• Opening up new comments in issue 1.3b Tooling Development (Smart Contracts) #26 regarding specifics on CreatePoolFromFactoryExample.s.sol, mainly revolving around what wallet is used for deployment/initialization, and which is used for front-end interactions.

Today

• Combine details from DeployCustomPoolFactoryExample.s.sol with CreatePoolFromFactoryExample.s.sol
• Make actual PR, debug compilation errors
• Update README with how things are meant to work for "off-the-shelf" use of ScaffoldBalancer tool.

Thoughts / Blockers / Questions

• Currently drafting up questions / requests for clarity in issue 1.3b Tooling Development (Smart Contracts) #26

[steve0xp]

April 19th Stand-Up

Yesterday

• Combine details from DeployCustomPoolFactoryExample.s.sol with CreatePoolFromFactoryExample.s.sol
• Make actual PR, debug compilation errors
• Thought through test template setup. Posting it in a new issue, but first want to clarify it to make sure questions are clear for Balancer Labs.

Today

• Clarifying questions related to tests && error I'm hitting when running DeployCustomPoolFactoryAndNewPoolExample.s.sol
• Adding more docs ideas to issue Docs CRs #17 and pinging BLabs on it. Might just open issues for them too on this if it is relevant.
  • Mainly about:
    • Testing with their repo as a custom pool developer (can we just run make test and have the vault carry out "Balancer scoped" tests similar to how Yearn strategies are tested against the Yearn architecture?). This would not be in the scope of this tooling project.
    • Use of custom factory for pool deployments, and aspects related to it.

Thoughts / Blockers / Questions

• I didn't set up that meeting with John for this week, so I'll request for one for next week.

[MattPereira]

April 19th

Yesterday

• Communicate with Balancer about the updates in response to feedback
• Offer more feedback on SDK to Balancer

Today

• Communicate about forked network options
• Review PR feedback from Darryl on Set up pool actions component #25

[MattPereira]

April 22nd

Weekend

• no progress to report

Today

• Finish polishing Set up pool actions component #25 and merge it
• Create a new FE issue based on rec from Darryl Rewrite pool action flows with useQuery and useMutation #30

[MattPereira]

April 23rd

Yesterday

• Finished polishing Set up pool actions component #25 and merged it
• Created a new FE issue based on rec from Darryl Rewrite pool action flows with useQuery and useMutation #30

Today

• Meeting with Balancer to figure out collaboration and next steps
• Work on how to run SE-2 on forked network #24

Thoughts / Blockers / Questions

• Would the Balancer SDK work with a pool that is only deployed to a forked network?
  • make on chain calls to mock the api call
• What is the plan moving forward?
  • Get to milestone 1 asap
• Handle errors on my side or SDK side?
  • Leave it to balancer for now

[steve0xp]

April 23rd Stand-Up

Yesterday / The Last Few Days

• Make actual PR, debug compilation errors
• Clarifying questions related to tests && error I'm hitting when running DeployCustomPoolFactoryAndNewPoolExample.s.sol
• Adding more docs ideas to issue Docs CRs #17 and pinging BLabs on it. Might just open issues for them too on this if it is relevant.

Today

• Scope/Schedule meeting with John Grants & Matt
• Fix PR Create Custom Pool Factory Example Contracts, Scripts, and Tests #29 Scripts and begin setting up test template referencing balancer monorepo && tests there for weighted pool type
• Review with Matt

Thoughts / Blockers / Questions

• From meeting with John and Matt today: I’ll provide update(s) by Thursday EoD on where we’re at with milestone 1, specifically the smart contracts as front end is almost complete. Depending on where things are at by EoW we may transition smart contracts work over to Balancer team. This is TBD based on this week's progress.

[MattPereira]

2024-04-24

Yesterday

• Code along with @steve0xp teaching me how to use v3 test comprehension to write script that uses pool factory contract to handle set up of new pool

Today

• Work on how to run SE-2 on forked network #24

Thoughts / Blockers / Questions

• At some point, I think we should migrate back to foundry version of SE-2 instead of hardhat 🙃

[steve0xp]

April 24th Stand-Up

Yesterday

• Scope/Schedule meeting with John Grants & Matt
• [/] Fix PR Create Custom Pool Factory Example Contracts, Scripts, and Tests #29 Scripts and begin setting up test template referencing balancer monorepo && tests there for weighted pool type - codealong with Matt showing him the process.

Today

• Continue fixing PR Create Custom Pool Factory Example Contracts, Scripts, and Tests #29 scripts and work on testing template

Thoughts / Blockers / Questions

• New issues to open but not prioritize:
  • Reformat foundry scripts to hardhat/TS (if needed)
  • Upgrade script and tests to use Permit2
  • Use Balancer Test ERC20 and mimic their test setup more so as to be in line with their development process

[MattPereira]

2024-04-25

Yesterday

• Started testing custom pools deployed through factory with the frontend
• Ran into bug and communicated with John about it on TG

Today

• Further front end testing of pools deployed through pool factory using temporary measures for join & exit query
• Explain SE-2 version decision btwn hardhat vs foundry in context of Create Custom Pool Factory Example Contracts, Scripts, and Tests #29

Thoughts / Blockers / Questions

• We are not taking advantage of SE-2 scripts with our current SE-2 Hardhat setup, either we should also write pool deployment scripts in hardhat or switch to ( back 😮‍💨 ) to Foundry version of SE-2
• There is also a new release of SE-2 since we started this one where they upgraded from viem v1 to viem v2 which is a pretty heavy lift from my understanding