Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dotenv - New feature request #7056

Closed
crazyoptimist opened this issue Oct 23, 2020 · 5 comments
Closed

Support dotenv - New feature request #7056

crazyoptimist opened this issue Oct 23, 2020 · 5 comments

Comments

@crazyoptimist
Copy link

Thanks for your efforts, maintainers and contributors.
Current implementation can not leverage dotenv@npm in case of using sails cli.
I guess it can be solved by a hook using dotenv npm package as a dependency.
Let me know your opinion guys.

@sailsbot
Copy link

@crazyoptimist Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@eashaw
Copy link
Member

eashaw commented Oct 29, 2020

Thanks for the feedback @crazyoptimist. I think you're right about implementing it as a hook, If you're feeling up to it you could make it an installable hook to make this available to other Sails users. https://sailsjs.com/documentation/concepts/extending-sails/hooks/installable-hooks#creating-an-installable-hook

@crazyoptimist
Copy link
Author

Okay,
I'll try to get some work done on this.

@crazyoptimist
Copy link
Author

crazyoptimist commented Oct 31, 2020

Bang!
I was about to reinvent the wheel. Here is an install-able hook: sails-hook-dotenv
And it turned out that this issue has not been resolved(already closed though 👎 )
When are you planning to look into defining hooks load sequence?
If someone stuck in dotenv, refer to this workaround.

@crazyoptimist
Copy link
Author

Let me close this issue for now assuming you have define hooks load sequence in your roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants