Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterFind callback #7059

Open
edmondsylar opened this issue Oct 26, 2020 · 3 comments
Open

afterFind callback #7059

edmondsylar opened this issue Oct 26, 2020 · 3 comments

Comments

@edmondsylar
Copy link

Hello,
Am trying to implement the afterFind callback in waterline but having an issue that i get duplicate records in my response its more like the callback is executed twice,
My Implementation looks like this

    if (!_.has(WLModel._callbacks, 'afterFind')) {
              return proceed(undefined, populatedRecords);
            }

   return WLModel._callbacks.afterFind(populatedRecords, function(err){
        if(err){ 
        return proceed(er);
     }

         return proceed(undefined, populatedRecords);
   });

and on my model file in config/model.js and trying to log the result.

  afterFind: function(records, proceed){
    Object.keys(records).forEach((elem) =>{
      sails.log(records[elem]);
    })
    
    return proceed();
  },

but In the response this is printed out twice, what could be the problem?, help needed Urgently.
Thank you

@sailsbot
Copy link

@edmondsylar Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@edmondsylar
Copy link
Author

edmondsylar commented Oct 26, 2020

The same issue is experienced also on afterFindOne

@eashaw
Copy link
Member

eashaw commented Oct 29, 2020

Hi @edmondsylar It's possible some other method might be using .find() under the covers, which might be part of reason these callbacks haven't been officially supported by Sails. It looks like you're using the code from balderdashy/waterline#1610, we'll take a closer look when we review that PR but that's my best guess for now. This information will be helpful when we test out that PR, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants