Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable KVM in x86_64 guest kernels #14

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

klutchell
Copy link
Collaborator

@klutchell klutchell commented Oct 20, 2023

Nested KVM is not supported on aarch64 hardware or kernels
so we can only enable this on x86_64 for now.

This functionality allows us to test KVM features via CI
on VM self-hosted GitHub runners. Hence "nested".

See: firecracker-microvm/firecracker#1721
See: #42

@flowzone-app flowzone-app bot enabled auto-merge October 20, 2023 14:30
@klutchell klutchell force-pushed the kyle/enable-guest-kvm branch 17 times, most recently from 4691f0d to 9710f60 Compare October 23, 2023 18:58
@klutchell klutchell marked this pull request as draft October 26, 2023 23:38
auto-merge was automatically disabled October 26, 2023 23:38

Pull request was converted to draft

@klutchell
Copy link
Collaborator Author

Nested KVM is not supported on any ARM64 hardware or kernels, so closing this PR.
See firecracker-microvm/firecracker#1721

@klutchell klutchell closed this Oct 26, 2023
@klutchell klutchell reopened this Nov 15, 2023
@klutchell klutchell force-pushed the kyle/enable-guest-kvm branch 3 times, most recently from 3467255 to 16ceaf0 Compare November 15, 2023 18:09
@klutchell klutchell marked this pull request as ready for review November 15, 2023 18:10
@klutchell klutchell marked this pull request as draft November 15, 2023 18:14
auto-merge was automatically disabled November 15, 2023 18:14

Pull request was converted to draft

@klutchell klutchell force-pushed the kyle/enable-guest-kvm branch 2 times, most recently from d1edebf to 1ffaf4e Compare December 11, 2023 21:02
Nested KVM is not supported on aarch64 hardware or kernels
so we can only enable this on x86_64 for now.

This functionality allows us to test KVM features via CI
on VM self-hosted GitHub runners. Hence "nested".

Change-type: patch
Signed-off-by: Kyle Harding <kyle@balena.io>
@klutchell klutchell changed the title Enable KVM in guest kernels Enable KVM in x86_64 guest kernels Dec 11, 2023
@klutchell klutchell marked this pull request as ready for review December 11, 2023 21:07
Signed-off-by: Kyle Harding <kyle@balena.io>
@klutchell
Copy link
Collaborator Author

I self-certify!

@flowzone-app flowzone-app bot merged commit d868086 into main Dec 12, 2023
48 checks passed
@flowzone-app flowzone-app bot deleted the kyle/enable-guest-kvm branch December 12, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant