Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login page to provide secure ui option #14

Open
maggie44 opened this issue Feb 18, 2022 · 3 comments
Open

Add login page to provide secure ui option #14

maggie44 opened this issue Feb 18, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@maggie44
Copy link
Contributor

maggie44 commented Feb 18, 2022

I moved this to next priority list as it is the last of the semi-significant refactors (famous last words, hopefully the last or one of the last at least). Requires some backend and frontend work.

Will likely look at it next week, but converting to an issue for any ideas or thoughts. At the moment I was thinking a simple password option, no usernames, with the smallest interface possible (just an input box that pops up) and controlled by a little padlock icon in the top right. Backend wise, was just going to store a hashed password in a .env file. Creating a database for this would seem excessive for only one user. Unless @nucleardreamer you can see any need for potential database use for features in the future, then it may be worth adding it in now?

Add option for hashed env var and if not then normal password env var, and if not then no password.

@mrpher
Copy link

mrpher commented Feb 18, 2022

Hey @Maggie0002 tracking here. I agree with your comments in the forums that the password should be a fleet variable. If thats the case then yes, no need for username.

@maggie44 maggie44 changed the title Add login page option to provide secure ui option #maggie Add login page option to provide secure ui option Feb 19, 2022
@maggie44
Copy link
Contributor Author

On second thoughts, it may be better to use a SQLite database. It’s excessive for storing one hash but it may prove useful to have in the future and as a starter project a simple database ready to go may be useful too. Will keep thinking it over, but leaning more the database route right now.

@nucleardreamer
Copy link
Contributor

I think adding SQlite is a good tool to have going forward. Adding the ability for anyone to use a store to keep something permanent (perhaps while configuring their own components) will be a very useful thing to have.

@mrpher mrpher mentioned this issue Feb 24, 2022
@maggie44 maggie44 added the help wanted Extra attention is needed label Mar 4, 2022
@maggie44 maggie44 changed the title Add login page option to provide secure ui option Add login page to provide secure ui option Mar 7, 2022
@nucleardreamer nucleardreamer self-assigned this Mar 24, 2022
@maggie44 maggie44 added ongoing discussion and removed help wanted Extra attention is needed labels Apr 21, 2022
@maggie44 maggie44 added enhancement New feature or request and removed ongoing discussion labels Dec 27, 2022
@maggie44 maggie44 moved this from @next to Next priority in balena Starter Interface Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants