add go todo app task #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakateja
requested changes
Oct 29, 2018
| func Connect() (*gorm.DB, error) { | ||
| db, err := gorm.Open("mysql", "root@/go-todo-app?charset=utf8&parseTime=True&loc=Local") | ||
|
|
||
| db.SingularTable(true) |
There was a problem hiding this comment.
Before use db here, please check err first. db could be nil if gorm.Open returns error.
Then db.SingularTable(true) can cause panic error if db is nil
Go: panic: runtime error: invalid memory address or nil pointer dereference
There was a problem hiding this comment.
i've added err check here https://github.com/bali-gophers/backpack/pull/7/files#diff-d15b797a03ae0fe42442c4308adfd7d4R11
| } | ||
|
|
||
| func Create(response http.ResponseWriter, request *http.Request) { | ||
| taskModel, err := decode(request) |
There was a problem hiding this comment.
before use taskModel, please check err first
There was a problem hiding this comment.
I've added err check here https://github.com/bali-gophers/backpack/pull/7/files#diff-47328041993fa3e8acb14f43b8f08bb1R35
|
Hi @rakateja , PR updated :) |
|
Hi @gusdecool, i'm sorry, just realised ur changes 🙇 🙇 |
rakateja
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #3
sample to-do-app using go language