Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable @openapi:ResourceInfo annotation for service type resource objects #7447

Closed
lnash94 opened this issue Dec 6, 2024 · 2 comments
Closed

Comments

@lnash94
Copy link
Member

lnash94 commented Dec 6, 2024

Description

No response

Steps to Reproduce

This @openapi:ResourceInfo annotation is currently available in only the service declaration node, Therefore we need to have the same behaviour in the service contract type as well.

import ballerina/http;
import ballerina/openapi;

# Optional multiline or single-line description in [CommonMark](http://commonmark.org/help/) or HTML.
@http:ServiceConfig {basePath: "/v1"}
type OASServiceType service object {
    *http:ServiceContract;
    @openapi:ResourceInfo{
        ...
    }
    resource function post users() returns string[];
};

And then we need to map those annotation details into the generated OpenAPI spec as well.

Version

2201.10.0

Environment Details (with versions)

No response

@lnash94
Copy link
Member Author

lnash94 commented Dec 9, 2024

This fix is already supported in the 2201.10.0 version and this was local machine caching issue

@lnash94 lnash94 closed this as completed Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant