From 5c58faee9bcac0021a8acbf9b6dd6966b9e79144 Mon Sep 17 00:00:00 2001 From: vil02 Date: Tue, 17 Oct 2023 20:18:54 +0200 Subject: [PATCH 1/3] [Automated] Update the native jar versions --- ballerina/Ballerina.toml | 6 +++--- ballerina/Dependencies.toml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ballerina/Ballerina.toml b/ballerina/Ballerina.toml index 81b8383b..6d70d8f4 100644 --- a/ballerina/Ballerina.toml +++ b/ballerina/Ballerina.toml @@ -1,7 +1,7 @@ [package] org = "ballerina" name = "task" -version = "2.5.0" +version = "2.5.1" authors = ["Ballerina"] keywords = ["task", "job", "schedule"] repository = "https://github.com/ballerina-platform/module-ballerina-task" @@ -15,8 +15,8 @@ graalvmCompatible = true [[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "task-native" -version = "2.5.0" -path = "../native/build/libs/task-native-2.5.0.jar" +version = "2.5.1" +path = "../native/build/libs/task-native-2.5.1-SNAPSHOT.jar" [[platform.java17.dependency]] path = "./lib/quartz-2.3.2.jar" diff --git a/ballerina/Dependencies.toml b/ballerina/Dependencies.toml index 8d04cf7a..0a9ee2c7 100644 --- a/ballerina/Dependencies.toml +++ b/ballerina/Dependencies.toml @@ -39,7 +39,7 @@ modules = [ [[package]] org = "ballerina" name = "task" -version = "2.5.0" +version = "2.5.1" dependencies = [ {org = "ballerina", name = "jballerina.java"}, {org = "ballerina", name = "lang.runtime"}, From 49a1cbe9ae46478fdddd41e986a19ab772ceeb1a Mon Sep 17 00:00:00 2001 From: vil02 Date: Tue, 17 Oct 2023 20:25:23 +0200 Subject: [PATCH 2/3] Make some Java classes proper utilities Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #5052. --- changelog.md | 1 + .../java/io/ballerina/stdlib/task/actions/TaskActions.java | 4 +++- .../src/main/java/io/ballerina/stdlib/task/utils/Utils.java | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changelog.md b/changelog.md index f30225af..afe66176 100644 --- a/changelog.md +++ b/changelog.md @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed [Enable non-quartz logs](https://github.com/ballerina-platform/ballerina-standard-library/issues/4282) +- [Make some of the Java classes proper utility classes](https://github.com/ballerina-platform/ballerina-standard-library/issues/5052) ## [2.3.0] - 2022-09-29 diff --git a/native/src/main/java/io/ballerina/stdlib/task/actions/TaskActions.java b/native/src/main/java/io/ballerina/stdlib/task/actions/TaskActions.java index 12a80605..1914f56c 100644 --- a/native/src/main/java/io/ballerina/stdlib/task/actions/TaskActions.java +++ b/native/src/main/java/io/ballerina/stdlib/task/actions/TaskActions.java @@ -44,7 +44,9 @@ * * @since 0.1.4 */ -public class TaskActions { +public final class TaskActions { + + private TaskActions() {} private static final int bound = 1000000; private static final String value = "1000"; diff --git a/native/src/main/java/io/ballerina/stdlib/task/utils/Utils.java b/native/src/main/java/io/ballerina/stdlib/task/utils/Utils.java index cde732b8..75559961 100644 --- a/native/src/main/java/io/ballerina/stdlib/task/utils/Utils.java +++ b/native/src/main/java/io/ballerina/stdlib/task/utils/Utils.java @@ -52,7 +52,9 @@ * * @since 0.995.0 */ -public class Utils { +public final class Utils { + + private Utils() {} private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss.SSS"); From 360e313c1bb3aedf119fadc22ba0ebb800508bd0 Mon Sep 17 00:00:00 2001 From: vil02 Date: Tue, 17 Oct 2023 20:27:17 +0200 Subject: [PATCH 3/3] Add missing dash. Use proper formatting of the change log. --- changelog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index afe66176..bfe5066e 100644 --- a/changelog.md +++ b/changelog.md @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Changed -[Enable non-quartz logs](https://github.com/ballerina-platform/ballerina-standard-library/issues/4282) +- [Enable non-quartz logs](https://github.com/ballerina-platform/ballerina-standard-library/issues/4282) - [Make some of the Java classes proper utility classes](https://github.com/ballerina-platform/ballerina-standard-library/issues/5052) ## [2.3.0] - 2022-09-29