Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.x] Fix OpenAPI spec generation issues for U10 patch #1781

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Nov 13, 2024

Purpose

Fixes:

  1. Fixed included record field overriding issue https://github.com/wso2-enterprise/internal-support-ballerina/issues/831
  2. Improvement: mapping constant values as default value in the generated OAS Support constant value expression for the default value mapping in OAS generation ballerina-library#7353

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests - Added

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@lnash94 lnash94 changed the title [2.1.x] Fix openapi spec generation issues [2.1.x] Fix openapi spec generation issues for u10 patch Nov 13, 2024
@lnash94 lnash94 changed the title [2.1.x] Fix openapi spec generation issues for u10 patch [2.1.x] Fix openapi spec generation issues for U10 patch Nov 13, 2024
@lnash94 lnash94 marked this pull request as ready for review November 13, 2024 12:02
@lnash94 lnash94 requested a review from TharmiganK November 13, 2024 12:02
@lnash94 lnash94 changed the title [2.1.x] Fix openapi spec generation issues for U10 patch [2.1.x] Fix OpenAPI spec generation issues for U10 patch Nov 13, 2024
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnash94 lnash94 merged commit 1533da5 into ballerina-platform:2.1.x Nov 18, 2024
4 checks passed
@HindujaB
Copy link
Contributor

This fix will be released with 2201.10.3 patch
ballerina-platform/ballerina-distribution#5823

@lnash94 lnash94 deleted the 2.1.x-fixes branch November 18, 2024 11:02
@HindujaB HindujaB added this to the 2201.10.3 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants