Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] Fix issue with the loss of existing configs in Config.toml file #315

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

sahanHe
Copy link
Contributor

@sahanHe sahanHe commented Oct 18, 2023

Purpose

Fixes:314

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@sahanHe sahanHe requested a review from daneshk as a code owner October 18, 2023 07:03
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4d07041) 84.73% compared to head (55c65ce) 84.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##            1.1.x     #315      +/-   ##
==========================================
- Coverage   84.73%   84.72%   -0.01%     
==========================================
  Files          42       42              
  Lines        3792     3791       -1     
  Branches      480      480              
==========================================
- Hits         3213     3212       -1     
  Misses        418      418              
  Partials      161      161              
Files Coverage Δ
...llerina/persist/nodegenerator/SourceGenerator.java 77.39% <ø> (-0.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahanHe sahanHe changed the title Fix issue with the loss of existing configs in Config.toml file [1.1.x] Fix issue with the loss of existing configs in Config.toml file Oct 18, 2023
@sahanHe
Copy link
Contributor Author

sahanHe commented Oct 18, 2023

@kalaiyarasiganeshalingam PRAM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sahanHe sahanHe merged commit a10081d into ballerina-platform:1.1.x Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants