Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostgreSQL as a datasource #325

Merged
merged 18 commits into from
Dec 7, 2023

Conversation

kaneeldias
Copy link
Contributor

@kaneeldias kaneeldias commented Nov 29, 2023

Purpose

$subject

Related: ballerina-platform/ballerina-library#5829

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@kaneeldias kaneeldias marked this pull request as ready for review November 30, 2023 11:01
gradle.properties Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3ac3b8d) 84.70% compared to head (0551d1f) 84.74%.

Files Patch % Lines
...i/src/main/java/io/ballerina/persist/cmd/Push.java 75.00% 4 Missing and 4 partials ⚠️
...c/main/java/io/ballerina/persist/cmd/Generate.java 0.00% 1 Missing ⚠️
...t/nodegenerator/syntax/clients/DbClientSyntax.java 90.00% 0 Missing and 1 partial ⚠️
...ist/nodegenerator/syntax/sources/DbSyntaxTree.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   84.70%   84.74%   +0.04%     
==========================================
  Files          42       42              
  Lines        3779     3822      +43     
  Branches      477      492      +15     
==========================================
+ Hits         3201     3239      +38     
- Misses        422      424       +2     
- Partials      156      159       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daneshk daneshk merged commit d226983 into ballerina-platform:main Dec 7, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants