Introspection Support for Bal Persist #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuvindu
reviewed
Feb 27, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_generate_72/main.bal
Outdated
Show resolved
Hide resolved
persist-cli-tests/src/test/resources/test-src/input/tool_test_pull_14_mysql/script.sql
Outdated
Show resolved
Hide resolved
...sts/src/test/resources/test-src/output/tool_test_generate_72/generated/db/persist_client.bal
Outdated
Show resolved
Hide resolved
persist-cli-tests/src/test/resources/test-src/output/tool_test_generate_86/persist/model.bal
Outdated
Show resolved
Hide resolved
persist-cli-tests/src/test/resources/test-src/input/tool_test_generate_72/persist/model.bal
Show resolved
Hide resolved
hasathcharu
force-pushed
the
rebased
branch
2 times, most recently
from
65c5f05 to
2e9e825
Compare
daneshk
reviewed
Mar 4, 2024
daneshk
reviewed
Mar 4, 2024
…VarChar and Char length, Decimal precision and scale fields
…ce name is not mapped correctly
…ey fields introduced through annotations
…rrectly due to the order in which the entities are organized
Bhashinee
reviewed
Mar 8, 2024
| } | ||
|
|
||
| public Module introspectDatabase() throws SQLException { | ||
| ScriptRunner sr = new ScriptRunner(connection); |
There was a problem hiding this comment.
Shouldn't we close this connection explicitly? Better to have it in a try block for proper resource management.
There was a problem hiding this comment.
The connection is instantiated in a try block in Pull.java
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspect/Introspector.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspect/Introspector.java
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspect/MySQLIntrospector.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspectiondto/SQLColumn.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspectiondto/SQLColumn.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspect/MySQLIntrospector.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspectiondto/SQLForeignKey.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/introspectiondto/SQLIndex.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 8, 2024
persist-cli/src/main/java/io/ballerina/persist/nodegenerator/SourceGenerator.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 82.43% 82.98% +0.54%
==========================================
Files 45 61 +16
Lines 3992 5241 +1249
Branches 513 665 +152
==========================================
+ Hits 3291 4349 +1058
- Misses 531 675 +144
- Partials 170 217 +47 ☔ View full report in Codecov by Sentry. |
daneshk
reviewed
Mar 13, 2024
daneshk
reviewed
Mar 13, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_generate_72/Ballerina.toml
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 13, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_generate_75/main.bal
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 13, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_pull_4_mysql/persist/model.bal
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 13, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_pull_5_mysql/persist/model.bal
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 14, 2024
daneshk
reviewed
Mar 14, 2024
persist-cli/src/main/resources/cli-help/ballerina-persist-pull.help
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 14, 2024
persist-cli/src/main/java/io/ballerina/persist/nodegenerator/syntax/utils/BalSyntaxUtils.java
Outdated
Show resolved
Hide resolved
|
daneshk
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To add introspection support to the
bal persistmodule. This introduces a new commandbal persist pullthat will introspect existing SQL databases, generate the data model and write it to thepersist/model.balfile.Fixes: ballerina-platform/ballerina-library/issues/6014
Checklist