Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for MySQL data types #334

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

hasathcharu
Copy link
Contributor

@hasathcharu hasathcharu commented Mar 16, 2024

Purpose

This pull request adds improved support to MySQL data types when introspecting an existing database. Changes required for tooling in annotations changed in #6180 are also included.

Fixes: #6180

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 84.16%. Comparing base (8a0b88d) to head (58eb2e7).

Files Patch % Lines
...ist/nodegenerator/syntax/utils/BalSyntaxUtils.java 79.51% 5 Missing and 12 partials ⚠️
...main/java/io/ballerina/persist/models/SQLType.java 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   83.75%   84.16%   +0.41%     
==========================================
  Files          63       63              
  Lines        5577     5659      +82     
  Branches      712      739      +27     
==========================================
+ Hits         4671     4763      +92     
+ Misses        681      667      -14     
- Partials      225      229       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasathcharu hasathcharu marked this pull request as ready for review March 16, 2024 09:38
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@daneshk daneshk merged commit 6a52b16 into ballerina-platform:main Mar 18, 2024
5 of 6 checks passed
@hasathcharu hasathcharu deleted the annotation-change branch March 18, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make changes to advanced SQL annotation definitions
2 participants