-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for MySQL data types #334
Merged
daneshk
merged 7 commits into
ballerina-platform:main
from
hasathcharu:annotation-change
Mar 18, 2024
Merged
Improve support for MySQL data types #334
daneshk
merged 7 commits into
ballerina-platform:main
from
hasathcharu:annotation-change
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 83.75% 84.16% +0.41%
==========================================
Files 63 63
Lines 5577 5659 +82
Branches 712 739 +27
==========================================
+ Hits 4671 4763 +92
+ Misses 681 667 -14
- Partials 225 229 +4 ☔ View full report in Codecov by Sentry. |
daneshk
reviewed
Mar 16, 2024
daneshk
reviewed
Mar 16, 2024
daneshk
reviewed
Mar 16, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_generate_101/persist/model.bal
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 16, 2024
persist-cli-tests/src/test/resources/test-src/output/tool_test_generate_101/persist/model.bal
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
daneshk
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds improved support to MySQL data types when introspecting an existing database. Changes required for tooling in annotations changed in #6180 are also included.
Fixes: #6180
Examples
Checklist