Fix the init command #336
Merged
Fix the init command #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 83.70% 84.05% +0.35%
==========================================
Files 63 63
Lines 5690 5671 -19
Branches 743 737 -6
==========================================
+ Hits 4763 4767 +4
+ Misses 698 681 -17
+ Partials 229 223 -6 ☔ View full report in Codecov by Sentry. |
daneshk
reviewed
Mar 19, 2024
| @@ -0,0 +1,78 @@ | |||
| /* | |||
| * Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org) All Rights Reserved. | |
| * Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org). |
daneshk
reviewed
Mar 19, 2024
| ". but found '%s' datasource.%n", Arrays.toString(SUPPORTED_DB_PROVIDERS.toArray()), datastore); | ||
| return; | ||
| } | ||
|
|
||
| if (Files.isDirectory(Paths.get(sourcePath, PERSIST_DIRECTORY, MIGRATIONS))) { | ||
| errStream.println("ERROR: reinitializing persistence after executing the migrate command is not " + | ||
| "permitted. please remove the migrations directory within the persist directory and try " + | ||
| "executing the command again."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Shall we remove this too? As we are not adding any configuration, this validation is not valid
daneshk
reviewed
Mar 20, 2024
| @@ -14,5 +14,5 @@ EXAMPLES | |||
| $ bal persist generate --help | |||
|
|
|||
| Generate client objects for the model definition file inside persist directory. | |||
| $ bal persist generate | |||
| $ bal persist generate --module persist --datastore mysql | |||
There was a problem hiding this comment.
SYNOPSIS
bal persist generate [--module <module name>]
[--datastore <store type>]
[<-h> | <--help>]
OPTIONS
--module <module name>
The name of the module to initialize the persistence layer. If not specified, the default module will be used.
--datastore <store type>
The type of the datastore to be used for persistence.
The supported datastores are 'inmemory', 'mysql', 'mssql', 'postgresql', 'googlesheets', and redis.
-h, --help
Print the usage details of all commands.
We need to mention the options like above here
daneshk
reviewed
Mar 20, 2024
| @@ -44,7 +58,9 @@ OPTIONS | |||
| BALLERINA COMMANDS | |||
| The below is a list of available subcommands: | |||
|
|
|||
| init Initialize the package for persistence | |||
| add Initialize the package for persistence. Used along with `bal build` command. | |||
There was a problem hiding this comment.
Suggested change
| add Initialize the package for persistence. Used along with `bal build` command. | |
| add Initialize the package for persistence and integrate the client generation to the `bal build` command. |
There was a problem hiding this comment.
Addressed the suggestions in 103a302
daneshk
previously approved these changes
Mar 20, 2024
Co-authored-by: Danesh Kuruppu <daneshk@users.noreply.github.com>
|
daneshk
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes:ballerina-platform/ballerina-library#6195
Examples
Checklist