Improve bal persist migrate and refactor test cases
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 84.26% 84.73% +0.46%
==========================================
Files 63 62 -1
Lines 5715 5608 -107
Branches 750 734 -16
==========================================
- Hits 4816 4752 -64
+ Misses 676 640 -36
+ Partials 223 216 -7 ☔ View full report in Codecov by Sentry. |
Refactor migration test assertion to ensure the generated sources are correct. Refactor test cases for more clearer intent. This commit is a WIP and more changes will be added.
This commit adds test cases for first time migration, third time migration, and addition of a new table to the model.
This commit adds support to optionality changes in fields, support for composite primary keys and related tests. Optianality changes are not yet fully tested.
This commit improves migration tool to support more scenarios such as composite primary keys. Some of the existing code were also refactored to improve the readability and maintainability. Tests were added to cover the new scenarios.
hasathcharu
force-pushed
the
refactor-migrate
branch
from
0ff19c9 to
ca04358
Compare
Bhashinee
reviewed
Apr 2, 2024
persist-cli-tests/src/test/java/io/ballerina/persist/tools/utils/GeneratedSourcesTestUtils.java
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
daneshk
reviewed
Apr 2, 2024
...-src/output/tool_test_migrate_5/persist/migrations/20240401060508_secondMigration/script.sql
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
...-src/output/tool_test_migrate_3/persist/migrations/20240401060627_secondMigration/script.sql
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
persist-cli-tests/src/test/resources/test-src/input/tool_test_migrate_13/Ballerina.toml
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
...st-src/input/tool_test_migrate_15/persist/migrations/20240329105157_firstMigration/model.bal
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
...t-src/output/tool_test_migrate_15/persist/migrations/20240329105157_firstMigration/model.bal
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
...src/output/tool_test_migrate_15/persist/migrations/20240401082915_secondMigration/script.sql
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Apr 2, 2024
daneshk
reviewed
Apr 2, 2024
daneshk
reviewed
Apr 2, 2024
persist-cli/src/main/java/io/ballerina/persist/cmd/Migrate.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a partial fix for the first issue linked below. This also fixes the issue where changes to optional types are not migrated correctly.
Fixes:
Checklist