Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persist dependency to the toml in the bal build instead of persist add #346

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented Apr 8, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#6295

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@Bhashinee Bhashinee marked this pull request as ready for review April 8, 2024 10:42
@Bhashinee Bhashinee changed the title Add dependency in the bal build instead of persist add Add persist dependencyto the toml in the bal build instead of persist add Apr 8, 2024
@Bhashinee Bhashinee changed the title Add persist dependencyto the toml in the bal build instead of persist add Add persist dependency to the toml in the bal build instead of persist add Apr 8, 2024
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bhashinee Bhashinee closed this Apr 9, 2024
@Bhashinee Bhashinee reopened this Apr 9, 2024
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Bhashinee Bhashinee merged commit 455c6f3 into ballerina-platform:main Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the persist native dependency with bal build instead of bal persist add
2 participants