Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mssql and postgresql drivers as dependencies #372

Merged
merged 1 commit into from
May 29, 2024
Merged

Add mssql and postgresql drivers as dependencies #372

merged 1 commit into from
May 29, 2024

Conversation

hasathcharu
Copy link
Contributor

@hasathcharu hasathcharu commented May 29, 2024 •
edited
Loading

Purpose

This PR is to fix the failing test cases arising from mssql drivers not being resolved when they are not available in the Ballerina Cache.

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@hasathcharu hasathcharu marked this pull request as ready for review May 29, 2024 11:59
daneshk
daneshk approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daneshk daneshk merged commit 85254bc into ballerina-platform:main May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneshk daneshk daneshk approved these changes

@sahanHe sahanHe Awaiting requested review from sahanHe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasathcharu @daneshk